Fix invalid array bounds during static analysis #518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes php-soap/wsdl-reader#26
@lstrojny : I decided to go this way since it is the easiest way to go forward.
The array-bounds will always be calculated based on int<0, maxOccurs - 1>:
When minOccurs > 0, the array will become a non-empty-array.
Examples:
This should solve your issue.
If someone cares enough to improve this, I'm always open into considering something like:
(limited to x amount of items to avoid too large shapes being generated)
Yet I think this should be sufficient for now.