WIP: First Laravel 11 working version #75
Conversation
| @@ -2,3 +2,4 @@ | |||
| composer.phar | |||
| composer.lock | |||
| .DS_Store | |||
| /.phpunit.result.cache | |||
There was a problem hiding this comment.
Please add the .idea folder as an ignore for the project, doesn't make sense to commit these files as we would via "with a team" perspective https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
| }, | ||
| "config": { | ||
| "allow-plugins": { | ||
| "kylekatarnls/update-helper": true, |
There was a problem hiding this comment.
Haven't seen this package before, interesting.
| $this->laravelDispatcher->fire($eventName, $event); | ||
| return $this->symfonyDispatcher->dispatch($eventName, $event); | ||
| if ($eventName !== null) { | ||
| // TODO: Someone who understands events under the hood more should look into this |
There was a problem hiding this comment.
What do you need to know?
Within https://github.com/php-tmdb/api/blob/4.1/lib/Tmdb/Event/Listener/RequestListener.php#L70 the request / response handling is done. Most of the other listeners are more "helpers" to add information to the request, or divert the response to a cached instance.
See how this is configured in symfony;
| use Tmdb\Laravel\TmdbServiceProviderLaravel4; | ||
| use Tmdb\Laravel\TmdbServiceProviderLaravel5; | ||
| use Tmdb\ApiToken; | ||
| use Tmdb\Laravel\TmdbServiceProviderLaravel; |
There was a problem hiding this comment.
These versions don't make any sense any more at all?
| $ed->addListener(BeforeRequestEvent::class, $jsonContentTypeListener); | ||
|
|
||
| $userAgentListener = new UserAgentRequestListener(); | ||
| $ed->addListener(BeforeRequestEvent::class, $userAgentListener); | ||
|
|
There was a problem hiding this comment.
You might wanna also add the other listeners here via configuration, it's optional though.
| - 7.1 | ||
| - 8.2 | ||
| - 8.3 | ||
| - 8.4 | ||
| - nightly | ||
| - hhvm |
There was a problem hiding this comment.
I think hhvm is dead by now?
Support for Laravel 11
Dropped support of Laravel 4/5
Support for API key and bearer token .env definition
Current PHP Unit test cases without deprecation warnings
TODO: