Declare strict types

php-lock · Dec 5, 2024 · ca35eef · ca35eef
1 parent a98afa2
commit ca35eef
Show file tree

Hide file tree

Showing 16 changed files with 34 additions and 12 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -55,20 +55,12 @@
         'return_assignment' => false,
         'comment_to_phpdoc' => false,
         'general_phpdoc_annotation_remove' => [
-            'annotations' => ['author', 'copyright', 'throws'],
+            'annotations' => ['author', 'copyright'],
         ],
 
         // fn => without curly brackets is less readable,
         // also prevent bounding of unwanted variables for GC
         'use_arrow_functions' => false,
-
-        // TODO disable too strict rules for now
-        'declare_strict_types' => false,
-        'general_phpdoc_annotation_remove' => false,
-        'php_unit_data_provider_static' => false,
-        'php_unit_strict' => false,
-        'phpdoc_to_comment' => false,
-        'strict_comparison' => false,
     ])
     ->setFinder($finder)
     ->setCacheFile(sys_get_temp_dir() . '/php-cs-fixer.' . md5(__DIR__) . '.cache');
diff --git a/tests/mutex/CASMutexTest.php b/tests/mutex/CASMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\exception\LockAcquireException;

diff --git a/tests/mutex/FlockMutexTest.php b/tests/mutex/FlockMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use Eloquent\Liberator\Liberator;

diff --git a/tests/mutex/LockMutexTest.php b/tests/mutex/LockMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\exception\LockAcquireException;

diff --git a/tests/mutex/MemcachedMutexTest.php b/tests/mutex/MemcachedMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\exception\LockReleaseException;

diff --git a/tests/mutex/MutexConcurrencyTest.php b/tests/mutex/MutexConcurrencyTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use Eloquent\Liberator\Liberator;

diff --git a/tests/mutex/MutexTest.php b/tests/mutex/MutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use Eloquent\Liberator\Liberator;

diff --git a/tests/mutex/PHPRedisMutexTest.php b/tests/mutex/PHPRedisMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\exception\LockAcquireException;

diff --git a/tests/mutex/PgAdvisoryLockMutexTest.php b/tests/mutex/PgAdvisoryLockMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\mutex\PgAdvisoryLockMutex;

diff --git a/tests/mutex/PredisMutexTest.php b/tests/mutex/PredisMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\exception\LockAcquireException;

diff --git a/tests/mutex/RedisMutexTest.php b/tests/mutex/RedisMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\exception\LockAcquireException;

diff --git a/tests/mutex/SpinlockMutexTest.php b/tests/mutex/SpinlockMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\exception\ExecutionOutsideLockException;

diff --git a/tests/mutex/TransactionalMutexTest.php b/tests/mutex/TransactionalMutexTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\mutex;
 
 use malkusch\lock\exception\LockAcquireException;
@@ -81,7 +83,7 @@ public function testExceptionRollsback(): void
         }
 
         $count = $pdo->query('SELECT count(*) FROM testExceptionRollsback')->fetchColumn();
-        self::assertEquals(0, $count);
+        self::assertSame(0, \PHP_VERSION_ID < 8_10_00 ? (int) $count : $count);
     }
 
     /**
@@ -123,7 +125,7 @@ public function testReplayTransaction(\Exception $exception): void
             ++$i;
 
             $count = $pdo->query('SELECT count(*) FROM testExceptionRollsback')->fetchColumn();
-            self::assertEquals(0, $count);
+            self::assertSame(0, \PHP_VERSION_ID < 8_10_00 ? (int) $count : $count);
 
             $pdo->exec('INSERT INTO testExceptionRollsback VALUES(1)');
 
@@ -134,7 +136,7 @@ public function testReplayTransaction(\Exception $exception): void
         });
 
         $count = $pdo->query('SELECT count(*) FROM testExceptionRollsback')->fetchColumn();
-        self::assertEquals(1, $count);
+        self::assertSame(1, \PHP_VERSION_ID < 8_10_00 ? (int) $count : $count);
 
         self::assertSame(5, $i);
     }

diff --git a/tests/util/DoubleCheckedLockingTest.php b/tests/util/DoubleCheckedLockingTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\util;
 
 use malkusch\lock\mutex\Mutex;

diff --git a/tests/util/LoopTest.php b/tests/util/LoopTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\util;
 
 use malkusch\lock\exception\TimeoutException;

diff --git a/tests/util/PcntlTimeoutTest.php b/tests/util/PcntlTimeoutTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace malkusch\lock\Tests\util;
 
 use malkusch\lock\exception\DeadlineException;