Skip Redis tests if REDIS_URIS is not defined

php-lock · Dec 4, 2024 · 99fb834 · 99fb834
1 parent b10b0a0
commit 99fb834
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 **[Requirements](#requirements)** |
 **[Installation](#installation)** |
 **[Usage](#usage)** |
-**[License](#license)** |
+**[License](#license)**
 
 # php-lock/lock
 

diff --git a/tests/mutex/MutexConcurrencyTest.php b/tests/mutex/MutexConcurrencyTest.php
@@ -279,9 +279,9 @@ public static function provideExecutionIsSerializedWhenLockedCases(): iterable
             }];
         }
 
-        $uris = getenv('REDIS_URIS') !== false ? explode(',', getenv('REDIS_URIS')) : false;
+        if (getenv('REDIS_URIS')) {
+            $uris = explode(',', getenv('REDIS_URIS'));
 
-        if ($uris) {
             $cases['PredisMutex'] = [static function ($timeout = 3) use ($uris): Mutex {
                 $clients = array_map(
                     static function ($uri) {

diff --git a/tests/mutex/PHPRedisMutexTest.php b/tests/mutex/PHPRedisMutexTest.php
@@ -74,9 +74,13 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $uris = explode(',', getenv('REDIS_URIS') ?: 'redis://localhost'); // @phpstan-ignore ternary.shortNotAllowed
+        if (!getenv('REDIS_URIS')) {
+            self::markTestSkipped('Redis server is needed');
+        }
+
+        $redisUris = explode(',', getenv('REDIS_URIS'));
 
-        foreach ($uris as $redisUri) {
+        foreach ($redisUris as $redisUri) {
             $uri = parse_url($redisUri);
 
             // original Redis::set and Redis::eval calls will reopen the connection
@@ -241,14 +245,14 @@ public static function provideSerializersAndCompressorsCases(): iterable
             [\Redis::SERIALIZER_PHP, \Redis::COMPRESSION_NONE],
         ];
 
-        if (defined('Redis::SERIALIZER_IGBINARY')) {
+        if (defined('Redis::SERIALIZER_IGBINARY') && extension_loaded('igbinary')) {
             $options[] = [
                 constant('Redis::SERIALIZER_IGBINARY'),
                 \Redis::COMPRESSION_NONE,
             ];
         }
 
-        if (defined('Redis::COMPRESSION_LZF')) {
+        if (defined('Redis::COMPRESSION_LZF') && extension_loaded('lzf')) {
             $options[] = [
                 \Redis::SERIALIZER_NONE,
                 constant('Redis::COMPRESSION_LZF'),
@@ -258,7 +262,7 @@ public static function provideSerializersAndCompressorsCases(): iterable
                 constant('Redis::COMPRESSION_LZF'),
             ];
 
-            if (defined('Redis::SERIALIZER_IGBINARY')) {
+            if (defined('Redis::SERIALIZER_IGBINARY') && extension_loaded('igbinary')) {
                 $options[] = [
                     constant('Redis::SERIALIZER_IGBINARY'),
                     constant('Redis::COMPRESSION_LZF'),