syscalls: create sys_statvfs syscalls #631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
14 tasks
badochov
force-pushed
the
badochov/sys_statvfs
branch
2 times, most recently
from
9ea9d85 to
b22533e
Compare
Darchiv
reviewed
Jan 20, 2025
| @@ -23,6 +23,7 @@ | |||
| #include "include/posix-poll.h" | |||
| #include "include/posix-socket.h" | |||
| #include "include/posix-stat.h" | |||
| #include "include/posix-statvfs.h" | |||
There was a problem hiding this comment.
Why isn't this file included in the PR?
posix/posix.h
Outdated
| @@ -77,6 +78,9 @@ extern int posix_chmod(const char *path, mode_t mode); | |||
| extern int posix_fstat(int fd, struct stat *buf); | |||
|
|
|||
|
|
|||
| extern int posix_statvfs(const char *path, int fd, struct statvfs *buf); | |||
There was a problem hiding this comment.
In posix.c, the last argument is called stat, not buf
posix/posix.c
Outdated
| msg.i.attr.type = atMode; | ||
|
|
||
| if ((proc_send(oidp->port, &msg) < 0) || (msg.o.err < 0)) { | ||
| (void)posix_fileDeref(f); |
There was a problem hiding this comment.
What if f is used uninitialized? If posix_getOpenFile() is performed with &f, then devp == NULL, so this branch isn't even taken when f is used.
badochov
force-pushed
the
badochov/sys_statvfs
branch
from
b22533e to
890bf16
Compare
JIRA: RTOS-965
badochov
force-pushed
the
badochov/sys_statvfs
branch
from
890bf16 to
c213150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-965
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
sys: implement fstatvfs libphoenix#397