Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mcxisp tool #55

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Add mcxisp tool #55

merged 1 commit into from
Aug 2, 2024

Conversation

agkaminski
Copy link
Member

@agkaminski agkaminski commented Jul 26, 2024 •
edited
Loading

JIRA: RTOS-881

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (mcxn94x).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@agkaminski agkaminski requested a review from lukileczo July 26, 2024 13:27
github-actions[bot]
github-actions bot reviewed Jul 26, 2024
View reviewed changes
mcxisp/mcxisp.c Outdated Show resolved Hide resolved
mcxisp/mcxisp.c Outdated Show resolved Hide resolved
This was referenced Jul 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
lukileczo
lukileczo reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@lukileczo lukileczo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and codespell comments are valid

mcxisp/mcxisp.c Outdated Show resolved Hide resolved
mcxisp/mcxisp.c Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jul 29, 2024
View reviewed changes
mcxisp/mcxisp.c Outdated Show resolved Hide resolved
mcxisp/mcxisp.c Outdated Show resolved Hide resolved
@agkaminski agkaminski force-pushed the agkaminski/n94x branch 2 times, most recently from ec1fc11 to 9ac6ab8 Compare July 29, 2024 12:02
@agkaminski agkaminski requested a review from lukileczo July 29, 2024 12:03
lukileczo
lukileczo reviewed Jul 29, 2024
View reviewed changes
mcxisp/mcxisp.c Outdated Show resolved Hide resolved
@agkaminski agkaminski requested a review from lukileczo July 29, 2024 15:20
lukileczo
lukileczo reviewed Jul 29, 2024
View reviewed changes
mcxisp/mcxisp.c Outdated Show resolved Hide resolved
@agkaminski
Add mcxisp tool
3eaf7cd 
JIRA: RTOS-881
@agkaminski agkaminski merged commit 8472cfa into master Aug 2, 2024
5 checks passed
@agkaminski agkaminski deleted the agkaminski/n94x branch August 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@lukileczo lukileczo lukileczo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agkaminski @lukileczo