Fixes passband history adding/parsing #979
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FITS file format provides a HISTORY keyword that was not used correctly in previous versions. This commit fixes that and improves the overall code. WIP!
…dependent) timestamps.
kecnry
reviewed
Nov 7, 2024
Comment on lines
-41
to
+39
| _url_tables_server = 'http://tables.phoebe-project.org' | ||
| _url_tables_server = 'https://staging.phoebe-project.org' |
There was a problem hiding this comment.
this definitely shouldn't be merged, right?
There was a problem hiding this comment.
It should be merged into feature-blending. Staging is running the blending version of phoebe within the server.
kecnry
reviewed
Nov 7, 2024
Co-authored-by: Kyle Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions, history was overloading the HISTORY keyword in fits files and implementing a custom -END- separator, thus defeating the purpose of the fits standard. This has now been replaced with multiple HISTORY entries in the fits files.
Also, the timestamps thus far were in the ctime() format, which is locale-dependent. The new format follows the ISO standard and is locale-independent.
All parsers are implemented to use either format.
This version is currently serving passbands on staging.phoebe-project.org and everything is working as expected. Thus, I propose to pull this into the blending feature branch and use it to serve the passbands from the official tables.phoebe-project.org API.