Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades for ES 2 #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

upgrades for ES 2 #25

wants to merge 2 commits into from

Conversation

sherzberg
Copy link

These changes allow gathering metrics from elasticsearch 2 instances. Prior to these changes, many warnings about missing stats would be logged.

@faxm0dem
Copy link

faxm0dem commented Dec 2, 2015

I didn't test this yet, but thanks!

@rgevaert
Copy link

This works and is backwards compatible. Only issue that I saw is that you now need to use X.Y.Z version numbers. In the original plugin it was enough to use X.Y version numbers. Now the plugin breaks. But it can be changed in the config file.

Also #17 is worth noticing. People running 2.X.Y are probably using the python elasticsearch module provided by Elastico and that clashes with the module naming...

@jnovack
Copy link

jnovack commented Feb 22, 2016

This works, and is backwards compatible, HOWEVER, not a drop-in replacement as the config needs to be modified for X.Y.Z as noted above.

<Plugin "python">
    ModulePath "/usr/lib64/collectd/"

    Import "elasticsearch"

    <Module "elasticsearch">
        Verbose false
-        Version "1.0"
+        Version "2.2.0"
        Cluster "elasticsearch"
    </Module>
</Plugin>

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants