Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deferred render #786

Closed
wants to merge 2 commits into from
Closed

Remove deferred render #786

wants to merge 2 commits into from

Conversation

joeldrapper
Copy link
Collaborator

@joeldrapper joeldrapper commented Sep 23, 2024

This change removes the deferred render pattern as something you can opt into and instead makes it the default behaviour, with one small difference. You can yield any content that was captured from the component. It is no longer vanished.

@hangsu
Copy link

hangsu commented Sep 23, 2024

Will this behavior be replaced with a def deferred = true as suggested in #784?

@joeldrapper
Copy link
Collaborator Author

joeldrapper commented Sep 23, 2024

Will this behavior be replaced with a def deferred = true as suggested in #784?

This is actually a sketch I wanted to run by @willcosgrove for how we could merge deferred render and normal rendering so you don’t need to pick. Essentially, you could remove all the include DeferredRenders without any other changes.

@joeldrapper joeldrapper force-pushed the remove-deferred-render branch from 98f5b27 to 062bbe8 Compare September 24, 2024 03:07
@joeldrapper joeldrapper marked this pull request as ready for review October 2, 2024 14:16
@joeldrapper joeldrapper force-pushed the remove-deferred-render branch from b037a6c to 062bbe8 Compare October 2, 2024 19:58
@joeldrapper joeldrapper force-pushed the remove-deferred-render branch from 062bbe8 to 5bdb791 Compare October 2, 2024 19:59
@joeldrapper joeldrapper closed this Oct 3, 2024
@joeldrapper joeldrapper deleted the remove-deferred-render branch October 3, 2024 12:26
@stephannv
Copy link
Contributor

stephannv commented Oct 3, 2024

@joeldrapper did this sketch fail? What are the plans about DeferredRender? I'm keeping an eye on this because my gem Phlex::Slotable depends on DeferredRender.

@joeldrapper
Copy link
Collaborator Author

Yeah, I think we’re going to have to keep things essentially the way they’ve always been. I was hoping to be able to merge them together but there are too many issues. Phlex becomes less flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants