feat: extend GattClient interface with enable/disable indication/noti…

…fication (#447) * feat: extend GattClient interface with enable/disable indication/notification * Update amp-embedded-infra-lib
philips-software · Nov 4, 2024 · 62be185 · 62be185
1 parent 1d0b6a2
commit 62be185
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -19,7 +19,7 @@ if (HALST_STANDALONE)
     FetchContent_Declare(
         emil
         GIT_REPOSITORY https://github.com/philips-software/amp-embedded-infra-lib.git
-        GIT_TAG        28ef5f86cf50a4b0d00207d7484f2332d1f7c024 # unreleased
+        GIT_TAG        e110c4d31115e2ae14e91bbc40f9cf0f4fa3cb7c # unreleased
     )
     FetchContent_MakeAvailable(emil)
 

diff --git a/hal_st/middlewares/ble_middleware/GattClientSt.cpp b/hal_st/middlewares/ble_middleware/GattClientSt.cpp
@@ -304,14 +304,12 @@ namespace hal
 
         really_assert(gattIndicationEvent.Connection_Handle == connectionHandle);
 
-        infra::Subject<services::GattClientStackUpdateObserver>::NotifyObservers([&gattIndicationEvent, &data](auto& observer)
+        infra::Subject<services::GattClientStackUpdateObserver>::NotifyObservers([this, &gattIndicationEvent, &data](auto& observer)
             {
-                observer.UpdateReceived(gattIndicationEvent.Attribute_Handle, data);
-            });
-
-        infra::EventDispatcherWithWeakPtr::Instance().Schedule([this, &gattIndicationEvent]()
-            {
-                this->HandleGattConfirmIndication(gattIndicationEvent.Attribute_Handle);
+                observer.IndicationReceived(gattIndicationEvent.Attribute_Handle, data, [this, &gattIndicationEvent]()
+                    {
+                        this->HandleGattConfirmIndication(gattIndicationEvent.Attribute_Handle);
+                    });
             });
     }
 
@@ -325,7 +323,7 @@ namespace hal
 
         infra::Subject<services::GattClientStackUpdateObserver>::NotifyObservers([&gattNotificationEvent, &data](auto& observer)
             {
-                observer.UpdateReceived(gattNotificationEvent.Attribute_Handle, data);
+                observer.NotificationReceived(gattNotificationEvent.Attribute_Handle, data);
             });
     }