ci: communicate image version via codespaces secret

philips-software · Jul 26, 2024 · e114d9c · e114d9c
1 parent 26db80e
commit e114d9c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.devcontainer/cpp-test/devcontainer.json b/.devcontainer/cpp-test/devcontainer.json
@@ -1,5 +1,4 @@
 {
   "image": "ghcr.io/philips-software/amp-devcontainer-cpp:${localEnv:IMAGE_VERSION}",
-  "workspaceFolder": "/workspaces/amp-devcontainer/.devcontainer/cpp/e2e/workspace",
-  "initializeCommand": "env"
+  "workspaceFolder": "/workspaces/amp-devcontainer/.devcontainer/cpp/e2e/workspace"
 }
diff --git a/.github/workflows/acceptance-test.yml b/.github/workflows/acceptance-test.yml
@@ -6,8 +6,8 @@ on:
   workflow_dispatch:
 
 concurrency:
-  group: ${{ github.ref }}-${{ github.workflow }}
-  cancel-in-progress: true
+  group: ${{ github.workflow }}
+  cancel-in-progress: false
 
 permissions:
   contents: read
@@ -24,14 +24,16 @@ jobs:
           persist-credentials: false
       - uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
-          node-version: 18
+          node-version: 20
       #- run: npm ci
       #- run: npx playwright install --with-deps
       - run: |
+          gh auth login -s codespace
+          gh secret set -a codespaces --body "pr-${{ github.event.pull_request.number }}"
           gh codespace create -R ${{ github.repository }} -b $HEAD_REF -m basicLinux32gb --devcontainer-path .devcontainer/${{ matrix.flavor }}-test/devcontainer.json
         env:
-          HEAD_REF: ${{ github.head_ref }}
           GH_TOKEN: ${{ secrets.TEST_GITHUB_TOKEN }}
+          HEAD_REF: ${{ github.head_ref }}
           IMAGE_VERSION: pr-${{ github.event.pull_request.number }}
       - run: cd .devcontainer/${{ matrix.flavor }}/e2e && npm test
         env: