Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved recovery kit ux #434

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

nimish-ks
Copy link
Member

@nimish-ks nimish-ks commented Jan 20, 2025

🔍 Overview

This PR makes improves the UX around viewing recovery kit in the settings screen.

💡 Proposed Changes

  • Added exception handling when an incorrect sudo password has been entered by the user
  • Added a spinner on the Unlock button to show a loading indicator when users entered a sudo password and clicks Unlock

🖼️ Screenshots or Demo

Screencast.From.2025-01-20.14-08-16.mp4

📝 Release Notes

Improved Phase recovery kit UX

🧪 Testing

  • Navigate to the settings screen and try to access the recovery kit, with a valid / invalid sudo password

➕ Additional Context

  • A 100ms delay has been added to the Unlock button state for DX reasons. Without it the Unlock button seems to execute the decryption process swiftly, but with the just the right amount of delay (disabled) state to potentially confuse the user.
await new Promise(resolve => setTimeout(resolve, 100))

💚 Did You...

  • Ensure linting passes (code style checks)?
  • Update dependencies and lockfiles (if required)
  • Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices? (Chromium/Firefiox)

@nimish-ks nimish-ks self-assigned this Jan 20, 2025
@nimish-ks nimish-ks merged commit eeb7666 into main Jan 22, 2025
6 checks passed
@nimish-ks nimish-ks deleted the feat--improved-recovery-kit-ux branch January 22, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants