Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app creation dx improvements #429

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nimish-ks
Copy link
Member

@nimish-ks nimish-ks commented Jan 14, 2025

🔍 Overview

This PR improves the product experience by - creating an example application when a user (owner) first signups and creates an application, get's rid of placeholder welcome screens (meant to solve legacy post signup redirection issues) along with minor changes to app creation flow.

💡 Proposed Changes

  • Create a new app (example-secrets) with development, staging, production environments and populate them with example secrets when a user first signsup and creates an organization
  • Removed the SuccessPane that was meant to be a middle stop from when a user has completed the signup flow and before they are redirected to the app home screen
  • Exclude the example app from the getting started flow orientation flow and prompt the user subtly to create their first app manually
  • Refactored the create new app modal: removed the create example secrets toggle, added a label to indicate the app secrets are encrypted with end-to-end encryption by default, added a info box explaining that the app will be initialized with development, staging, production environments

🖼️ Screenshots or Demo

image

🧪 Testing

  • Tested the post signup redirection on Chrome (chromium) and Firefox
  • Tested signup flows where the password saved/unsaved by the user

🎯 Reviewer Focus

@rohan-chaturvedi This PR adds a app name as a param to the graphql query: https://github.com/phasehq/console/pull/429/files#diff-92f0d4418d07fba628f751b36d6739dcb85620bba824c9007bd63cf0fc3578b9R4, lmk if need to regenerate types or something on the backend.

➕ Additional Context

Provide any additional information that might be helpful for reviewers and future contributors, such as links to related issues, discussions, or resources.

✨ How to Test the Changes Locally

  • Sign up and create a new account - verify that the post onboarding redirection send you to your team home, verify that the create a new app step in getting started is not completed (because of the example app), go to the apps screen and verity that example-secrets app is present.
  • Open the example-secrets app, ensure the dummy secrets have been created across development, staging and production environments
  • Create a new application, verify that the development, staging, production environments are present with no secrets (blank), add members and service account to the app, verify secret access inside of environments from a user personal access token, and service account token.
  • Go to the home screen and verify if create a new app step has been completed after creating a new application manually

💚 Did You...

  • Ensure linting passes (code style checks)?
  • Update dependencies and lockfiles (if required)
  • Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

@nimish-ks nimish-ks marked this pull request as draft January 14, 2025 08:17
@nimish-ks nimish-ks changed the title Feat: app creation dx improvements feat: app creation dx improvements Jan 14, 2025
@nimish-ks nimish-ks marked this pull request as ready for review January 15, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant