Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tree list for navigation to apps and envs in the sidebar #265 #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshith-1008
Copy link
Contributor

@harshith-1008 harshith-1008 commented Jul 31, 2024

Changed the sidebar and team layout components.

🔍 Overview

I have created a tree list navigation for easier navigation through apps and their environments.

💡 Proposed Changes

•Changed the layout.tsx file inside the [team] folder, to fetch query and send props.
•Changed the sidebar.tsx component for fitting the logic and links for the apps and environments.

🖼️ Screenshots or Demo

Before:
WhatsApp Image 2024-07-31 at 19 48 53
After:
image
image

📝 Release Notes

•New feature: Added a tree list navigation.
•Improvement: Its dynamic and changes when apps are deleted or added.
•UI: Added a scrollbar for scrolling through the sidebar.

❓ Open Questions

•I need help with the actual tree lines, mention any packages/ideas I could use to recreate it.
•Provide all test cases as I may not have covered them all.

🧪 Testing

•I have tested all links.
•I have tested light mode and dark mode UI.
•I have tested adding and deleting of apps.

🎯 Reviewer Focus

•Go through layout.tsx file in [teams] folder.
•Go through Sidebar.tsx in components/layout folder

➕ Additional Context

•Fixed issue: #265

✨ How to Test the Changes Locally

•Pull latest code from this branch.
•Ensure your local environment is up and running.
•Review all test cases.

💚 Did You...

  • Ensure linting passes (code style checks)?
  • Update dependencies and lockfiles (if required)
  • Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

Changed the sidebar and team layout components.
@harshith-1008
Copy link
Contributor Author

harshith-1008 commented Aug 9, 2024

@rohan-chaturvedi could you look into this, also how can I retrieve LICENSE file, without losing license folder.

@rohan-chaturvedi rohan-chaturvedi self-requested a review August 9, 2024 10:05
@rohan-chaturvedi
Copy link
Member

@harshith-1008 Sure, however the UI implementation doesn't seem complete yet:

  • No branch lines
  • "Cube" icons not required on the App buttons
  • App chevrons don't match the expanded or collapsed state

image

For the license, maybe just grab it from main and restore the file to its original state.

@harshith-1008
Copy link
Contributor Author

image Could you provide me any logic/libraries I can implement for the tree system, I have no clue and I have added it on open questions as well.

@rohan-chaturvedi
Copy link
Member

@harshith-1008 Sorry, missed the open question on the PR. For the tree ui, you could try using just divs with borders and position them either with absolute positioning or use margin properties. Check out the secret history dialog for an example:

<div className="space-y-4 pb-4 border-l border-zinc-300 dark:border-zinc-700">

@harshith-1008
Copy link
Contributor Author

harshith-1008 commented Aug 16, 2024

@rohan-chaturvedi Is this fine?
image

@harshith-1008
Copy link
Contributor Author

harshith-1008 commented Aug 16, 2024

@rohan-chaturvedi also for height of the line i have a static and dynamic method, could you inform me on what I should use.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants