Add a simple code file editor so that we can use it for the preferences. #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It replaces the UIManager default edit: So we can remove this edit: method too.
jecisc
approved these changes
Oct 1, 2024
demarey
reviewed
Oct 1, 2024
| add: (SpBoxLayout newLeftToRight | ||
| add: label expand: true; | ||
| yourself) | ||
| height: self calculateLabelHeight; |
There was a problem hiding this comment.
it is not recommanded to hardcode the height in Spec.
Using expand: false on the TopToBottom layout should be enough.
^ SpBoxLayout newTopToBottom
spacing: 5;
add: (SpBoxLayout newLeftToRight
add: label expand: true;
yourself)
expand: false;
add: codeText;
yourself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It replaces the UIManager default edit: So we can remove this edit: method too.