merge latest #1565
Merged
merge latest #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t completely there.
…ator, but it does its job :P)
…presenter (if any) fixes pharo-project/pharo#16792
…ause just clicking is too restrictive)
|
hey @jecisc can you take a look at this? |
|
I'm debugging in an image and it seems that we indeed have a bug between traits and protocols.. Protocols should not be nil |
|
This happens only on those 2 methods and I don't know what is special about them... 
|
|
This one is really not easy to debug :/ |
jecisc
added a commit
to jecisc/pharo
that referenced
this pull request
Jul 23, 2024
It happens currently that some methods copied from traits are not well categorized with their protocols. This happens because we add the Traits methods in the class we are compiling before we copy the old protocols of the class. I'm fixing the problem be copying the old protocols sooner and I'm adding a regression test that was failing before and is now passing. This should fix the CI failures of pharo-spec/Spec#1565 and pharo-spec/Spec#1573
jecisc
added a commit
that referenced
this pull request
Jul 24, 2024
Revert "Merge pull request #1565 from pharo-spec/dev-3.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.