-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove more unsent methods that send non-existing selectors. #1417
Conversation
Looks good to me but I'm not spec expert. |
but there are dependencies affected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason there are dependencies that seems accepted.
This is not due to this change, this is failing since some time |
there are all these affected: ✗ #testCollectionsShouldNotDependOnRandom (1263ms) |
yes, this is failing for all the PRs, not just this one. |
I found the origin of this problem and I and currently doing a PR to Pharo. I tried to find the problem since a long time but I just fount it yesterday. |
This should fix by pharo-project/pharo#14404 (I hope) |
Only two unrelated failures left |
This is dead code.