Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove more unsent methods that send non-existing selectors. #1417

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

MarcusDenker
Copy link
Contributor

This is dead code.

@Ducasse
Copy link
Contributor

Ducasse commented Jul 2, 2023

Looks good to me but I'm not spec expert.

@Ducasse Ducasse requested a review from estebanlm July 2, 2023 14:36
@estebanlm estebanlm closed this Jul 3, 2023
@estebanlm estebanlm reopened this Jul 3, 2023
@estebanlm
Copy link
Member

but there are dependencies affected.

@estebanlm estebanlm self-requested a review July 3, 2023 13:25
Copy link
Member

@estebanlm estebanlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason there are dependencies that seems accepted.

@MarcusDenker
Copy link
Contributor Author

This is not due to this change, this is failing since some time

#1415

@estebanlm
Copy link
Member

there are all these affected:

✗ #testCollectionsShouldNotDependOnRandom (1263ms)
✗ #testExternalBasicToolsDependencies (1251ms)
✗ #testExternalCompilerDependencies (1252ms)
✗ #testExternalDisplayDependencies (1279ms)
✗ #testExternalFileSystemDependencies (1239ms)
✗ #testExternalIDEDependencies (1362ms)
✗ #testExternalKernelDependencies (1250ms)
✗ #testExternalLocalMonticelloDependencies (1236ms)
✗ #testExternalMetacelloDependencies (1239ms)
✗ #testExternalMonticelloDependencies (1246ms)
✗ #testExternalMorphicCoreDependencies (1238ms)
✗ #testExternalMorphicDependencies (1232ms)
✗ #testExternalSUnitDependencies (1255ms)
✗ #testExternalSUnitKernelDependencies (1227ms)
✗ #testExternalSpec2Dependencies (1249ms)
✗ #testExternalUFFIDependencies (1226ms)
✗ #testExternalUIDependencies (1398ms)
✗ #testFilesShouldNotDependOnRandom (1347ms)

@MarcusDenker
Copy link
Contributor Author

yes, this is failing for all the PRs, not just this one.

@jecisc
Copy link
Member

jecisc commented Aug 1, 2023

I found the origin of this problem and I and currently doing a PR to Pharo. I tried to find the problem since a long time but I just fount it yesterday.

@jecisc
Copy link
Member

jecisc commented Aug 1, 2023

This should fix by pharo-project/pharo#14404 (I hope)

@jecisc jecisc closed this Aug 3, 2023
@jecisc jecisc reopened this Aug 3, 2023
@jecisc
Copy link
Member

jecisc commented Aug 3, 2023

Only two unrelated failures left

@jecisc jecisc merged commit 30a040e into pharo-spec:Pharo12 Aug 3, 2023
1 of 2 checks passed
@MarcusDenker MarcusDenker deleted the DeadCode-Clean-01-07 branch August 7, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants