-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #28 update advs vignette #46
base: main
Are you sure you want to change the base?
Conversation
…hropometric measurement"
…r update to parcat1 of BMI at a later section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one minor comment.
Upon reviewing, I am also thinking our test data could be improved. As it stands, everyone is in obesity class II and noone shows a 5% (let alone 10 or 15) reduction in BMI.
@Siddhesh2097 @AndersAskeland @pharmaverse/admiralmetabolic what do you think? If weagree, could you make an issue and mark as "good first issue"?
"BMI", "BMI", "Body Mass Index(kg/m^2)", 3, "Subject Characteristic", 1, | ||
"HIPCIR", "HIPCIR", "Hip Circumference (cm)", 4, "Subject Characteristic", 1, | ||
"WSTCIR", "WSTCIR", "Waist Circumference (cm)", 5, "Subject Characteristic", 1, | ||
"HEIGHT", "HEIGHT", "Height (cm)", 1, "Anthropometric measurement", 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but can we capitalise "Measurement" throughout?
Yes, I agree. vs needs an update. |
could you pls make an issue? might be a good one for one of our newcomers - @kiwi5104679 maybe you could take it? I can help support. |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral<ext> (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()