Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1839 Dummy function created #1958

Closed
wants to merge 10 commits into from
Closed

Conversation

ashachakma
Copy link
Collaborator

@ashachakma ashachakma commented Jun 14, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@ashachakma ashachakma added the onboarding Brining in the masses! label Jun 14, 2023
@ashachakma ashachakma requested a review from bms63 June 14, 2023 06:33
@ashachakma ashachakma self-assigned this Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Code Coverage

Package Line Rate Health
admiral 99%
Summary 99% (4191 / 4247)

@bms63
Copy link
Collaborator

bms63 commented Jun 14, 2023

Make sure to go through each checklist item and complete when relevant - if not relevant then just sign off as well.

Also - make a section in the News for your update

R/test-my_first_fcn.R Outdated Show resolved Hide resolved
@ashachakma ashachakma linked an issue Jun 15, 2023 that may be closed by this pull request
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file shouldn't be updated

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do a quick update to the news file as well.

@bms63
Copy link
Collaborator

bms63 commented Jul 5, 2023

Hi @ashachakma just to wrap this up:

  • can you click the update branch button to get that experience
    image
  • Create a blurb in the news.md file

Then we can close this out.

@ashachakma
Copy link
Collaborator Author

Hi @ashachakma just to wrap this up:

  • can you click the update branch button to get that experience
    image
  • Create a blurb in the news.md file

Then we can close this out.

Its done now.

@bms63
Copy link
Collaborator

bms63 commented Jul 5, 2023

oh - actually see if you can fix the spelling check that is failing. that is a good one to know.

@bms63 bms63 closed this Jul 19, 2023
@bms63 bms63 deleted the 1839_dummyissue@devel branch July 19, 2023 20:25
@bms63 bms63 removed a link to an issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Brining in the masses!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants