Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the examples, so they run as tests #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kpacha
Copy link
Contributor

@kpacha kpacha commented Dec 4, 2015

... and cover the Unmarshal function too

@phamhongviet
Copy link
Owner

Isn't it already done in https://github.com/phamhongviet/godsv/blob/master/godsv_test.go#L9 ?
May be I should put simple examples for Marshal and Unmarshal in readme.

@kpacha
Copy link
Contributor Author

kpacha commented Dec 4, 2015

This way, you are also black-box testing the lib, because these code is outside the godsv package, so it has the same visibility clients have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants