Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Mvc\Model\Row class that extends from stdClass #16375

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

escribiendocodigo
Copy link
Contributor

Deprecated: Creation of dynamic property

  • I already have it. After, If I use find/findFirst without columns, joins, etc. I have returned a model object and all is correct here, but If you use joins, columns, etc. you receive a ResultSet with \Phalcon\Mvc\Model\Row objects, with all properties needed injected, and get a lot of messages like this: Deprecated: Creation of dynamic property \Phalcon\Mvc\Model\Row::$id is deprecated

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@niden
Copy link
Member

niden commented Jul 17, 2023

@escribiendocodigo Can you please issue the PR without the ext/ folder changes? It will mess things up for us when we next release.

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jul 17, 2023
@niden niden linked an issue Jul 17, 2023 that may be closed by this pull request
@niden niden merged commit 0ef25e4 into phalcon:5.0.x Jul 17, 2023
38 checks passed
@niden
Copy link
Member

niden commented Jul 17, 2023

Thank you @escribiendocodigo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Creation of dynamic property TestTask::$db is deprecated
2 participants