Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of string conversion errors on Windows #6

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Better handling of string conversion errors on Windows #6

merged 1 commit into from
Jan 10, 2024

Conversation

PeterTh
Copy link
Member

@PeterTh PeterTh commented Jan 10, 2024

Previously, when string conversion failed the library might access the value of an unset std::optional.

@PeterTh PeterTh requested a review from BlackMark29A January 10, 2024 11:36
BlackMark29A
BlackMark29A approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@BlackMark29A BlackMark29A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@BlackMark29A BlackMark29A merged commit f1076eb into main Jan 10, 2024
8 checks passed
@BlackMark29A BlackMark29A deleted the handle-convert-errors branch January 10, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackMark29A BlackMark29A BlackMark29A approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterTh @BlackMark29A