Move PID deletion out of DEMOLISH method #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no guarantee from Perl that it's called in a timely manner or order when shutting down. The `pid_file` field may no longer be set. This might explain why the PID file was never cleaned up. Move it instead to the `run` method, where it should always run once a signal handler has set `continue` to false. It exits the loop on the next run, then cleans up the PID file before exiting. At least that's the idea. Move the PID test to the `run` test section of `t/consumer.t`, since `run` is where it happens now.
|
Not sure how this PR became closed, but I reopened it as #80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no guarantee from Perl that it's called in a timely manner or order when shutting down. The
pid_filefield may no longer be set. This might explain why the PID file was never cleaned up.Move it instead to the
runmethod, where it should always run once a signal handler has setcontinueto false. It exits the loop on the next run, then cleans up the PID file before exiting. At least that's the idea.Move the PID test to the
runtest section oft/consumer.t, sincerunis where it happens now.