Add v1-v2 release conversion #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 10 +2
Lines 1034 1083 +49
=========================================
+ Hits 1034 1083 +49 ☔ View full report in Codecov by Sentry. |
theory
force-pushed
the
port-v1-release
branch
from
c1f24b7 to
ee4a514
Compare
vrmiguel
reviewed
Sep 23, 2024
| for (name, patches, expect) in [ | ||
| ( | ||
| "license", | ||
| vec![json!({"license": "MIT"})], |
There was a problem hiding this comment.
Suggested change
| vec![json!({"license": "MIT"})], | |
| &[json!({"license": "MIT"})], |
Doing this I believe you could skip the .as_slice() below
There was a problem hiding this comment.
Sadly that doesn't work because the third item in the list has two items in the vector, not one, so it complains with
mismatched types
expected reference `&[serde_json::Value; 1]`
found reference `&[serde_json::Value; 2]`
vrmiguel
approved these changes
Sep 23, 2024
theory
force-pushed
the
release-struct
branch
from
2923488 to
88b2183
Compare
Dupe the pattern from the `meta` package by adding `v1` and `v2` sub-packages that know how to parse into the canonical form. Make `meta::v1` public to the crate so that `release::v1` can use it to migrate everything but the release metadata, then add `v1_to_v2_release` to handle that bit. The v2 `release` object takes the form of a JWS-JS data structure, but since we're not signing anything yet, and this is just to get things to load properly, for now just generate random values for the JWS header and signature. Enable the v1 corpus tests and add a test for merging v1 release metadata. While at it, change the `uri` property to start with `dist` instead of `/dist`, because the latter implies relative to the root of a domain, and mirrors may not serve from a domain root.
theory
force-pushed
the
port-v1-release
branch
from
ee4a514 to
b239fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dupe the pattern from the
metapackage by addingv1andv2sub-packages that know how to parse into the canonical form. Makemeta::v1public to the crate so thatrelease::v1can use it to migrate everything but the release metadata, then addv1_to_v2_releaseto handle that bit.The v2
releaseobject takes the form of a JWS-JS data structure, but since we're not signing anything yet, and this is just to get things to load properly, for now just generate random values for the JWS header and signature.While at it, change the
uriproperty to start withdistinstead of/dist, because the latter implies relative to the root of a domain, and mirrors may not serve from a domain root.