Provide image for v17 #48
Conversation
| # LC_COLLATE and LC_TYPE have been removed with PG v16 | ||
| # https://www.postgresql.org/docs/release/16.0/ | ||
| if [ "${PGVER}" -lt 16 ]; then | ||
| COLLATE=$(echo 'SHOW LC_COLLATE' | "${OLDPATH}/bin/postgres" --single -D "${OLD}" "${POSTGRES_DB}" | grep 'lc_collate = "' | cut -d '"' -f 2) | ||
| CTYPE=$(echo 'SHOW LC_CTYPE' | "${OLDPATH}/bin/postgres" --single -D "${OLD}" "${POSTGRES_DB}" | grep 'lc_ctype = "' | cut -d '"' -f 2) | ||
|
|
||
| POSTGRES_INITDB_ARGS="--locale=${COLLATE} --lc-collate=${COLLATE} --lc-ctype=${CTYPE} --encoding=${ENCODING}" | ||
| else | ||
| POSTGRES_INITDB_ARGS="--encoding=${ENCODING}" | ||
| fi |
There was a problem hiding this comment.
not sure if there are any consequences when leaving out --lc-collate when booting a Postgres v16 database ...
There was a problem hiding this comment.
Good catch. I guess we'll find out, though no-one's raised any issues yet and it's been about a year. 😬
| @@ -0,0 +1,58 @@ | |||
| version: "2.1" | |||
| x-redash-service: &redash-service | |||
| image: redash/redash:10.1.0.b50633 | |||
There was a problem hiding this comment.
on another note: do we want to update this version at some point?
There was a problem hiding this comment.
We will at some point, but there hasn't been a new official Redash release since. We (the Redash team) are getting close to that happening, but there's a final major bug being worked on currently. 😄
|
This works great, just used this PR to upgrade a db from 16 to 17 and it worked well. |
There was a problem hiding this comment.
Looks good to me. Thanks for getting this done @andyundso. 😄
This PR provides a new image for Postgres v17.
@justinclift from what I've seen in the code, we actually do not have to provide a new
build-17build stage, since we only need to compile Postgres when upgrading from that version. Since we do not need to upgrade from v17 at the moment, this is not needed.Closes #47.