Do not reindex concurrently on PG < v16

Dockerfile.alpine

@@ -168,9 +168,9 @@ RUN if [ "${PGTARGET}" -eq 14 ]; then rm -rf /usr/local-pg14 /usr/local-pg15 /us
 RUN if [ "${PGTARGET}" -eq 15 ]; then rm -rf /usr/local-pg15 /usr/local-pg16; fi
 RUN if [ "${PGTARGET}" -eq 16 ]; then rm -rf /usr/local-pg16; fi
 
-# Install locale
+# Install locale and bc command for comparisons
 RUN apk update && \
-  apk add --update icu-data-full musl musl-utils musl-locales tzdata && \
+  apk add --update bc icu-data-full musl musl-utils musl-locales tzdata && \
   apk cache clean
 
 ## FIXME: Only useful while developing this Dockerfile

Dockerfile.bookworm

@@ -166,9 +166,9 @@ RUN if [ "${PGTARGET}" -eq 14 ]; then rm -rf /usr/local-pg14 /usr/local-pg15 /us
 RUN if [ "${PGTARGET}" -eq 15 ]; then rm -rf /usr/local-pg15 /usr/local-pg16; fi
 RUN if [ "${PGTARGET}" -eq 16 ]; then rm -rf /usr/local-pg16; fi
 
-# Install locale
+# Install locale and bc command for comparisons
 RUN apt update && \
-  apt install -y icu-devtools locales tzdata && \
+  apt install -y bc icu-devtools locales tzdata && \
   apt clean
 
 # Pass the PG build target through to the running image

README.md

@@ -76,7 +76,7 @@ $ docker run --name pgauto -it \
 	<NAME_OF_THE_PGAUTOUPGRADE_IMAGE>
 ```
 
-### Skip reindexing
+### Reindexing
 
 By default, all databases are reindexed after the migration, which can take some time if they are large.
 To skip reindexing, set the environment variable `PGAUTO_REINDEX` to `no`, for example:
@@ -89,6 +89,9 @@ $ docker run --name pgauto -it \
 	<NAME_OF_THE_PGAUTOUPGRADE_IMAGE>
 ```
 
+> [!WARNING]
+> PG v15 and below do not support reindexing system tables in a database concurrently. This means, when we run start the indexing operation, database locks are placed which do not allow for any modifications as long as the task is running. We recommend using PG v16 or v17 where this is not an issue.
+
 # For Developers
 
 ## Building the image

pgautoupgrade-postupgrade.sh

@@ -58,19 +58,12 @@ if [ "x${PGAUTO_REINDEX}" != "xno" ]; then
         echo "------------------------"
         echo "Reindexing the databases"
         echo "------------------------"
-
-        # For each database, reindex it
-        for DATABASE in ${DB_LIST}; do
-        	echo "-------------------------------"
-        	echo "Starting reindex of ${DATABASE}"
-        	echo "-------------------------------"
-
-        	echo 'REINDEX DATABASE CONCURRENTLY' | psql --username="${POSTGRES_USER}" -t --csv "${DATABASE}"
-
-        	echo "-------------------------------"
-        	echo "Finished reindex of ${DATABASE}"
-        	echo "-------------------------------"
-        done
+
+		if [[ $(echo "15 <= $PGTARGET" | bc) -eq 0 ]]; then
+			reindexdb --all --username="${POSTGRES_USER}"
+		else
+			reindexdb --all --concurrently --username="${POSTGRES_USER}"
+		fi
 
         echo "-------------------------------"
         echo "End of reindexing the databases"