Preparing for release 3.7.0

.github/dependabot.yml

@@ -4,3 +4,11 @@ updates:
   directory: "/"
   schedule:
       interval: "weekly"
+  target-branch: main
+
+#develop branch starts here
+- package-ecosystem: "github-actions"
+  directory: "/"
+  schedule:
+      interval: "weekly"
+  target-branch: develop

.github/scripts/tidy-vs-commit.sh

@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+# Runs clang-tidy only on changed files
+
+readonly BASE=$1
+readonly BUILD_DIR=build
+
+MODIFIED_FILES=$(git diff-tree --no-commit-id --diff-filter=d --name-only -r "$BASE" HEAD | grep '\.c')
+MODIFIED_HEADERS=$(git diff-tree --no-commit-id --diff-filter=d --name-only -r "$BASE" HEAD | grep '\.h')
+POSTGRES_SERVER=$(grep -o -m1 '\-isystem .*' "${BUILD_DIR}/compile_commands.json" | head -1 | awk '{print $2}')
+
+echo "POSTGRES_SERVER ${POSTGRES_SERVER}"
+
+CHECKS="-checks=clang-analyzer-*"
+
+if [ -z "${MODIFIED_FILES}" ] && [ -z "${MODIFIED_HEADERS}" ]; then
+  echo "No paths modified"
+  exit 0
+fi
+
+# C/C++ use the compile command
+if [ ${#MODIFIED_FILES[@]} != 0 ] ; then
+    for f in ${MODIFIED_FILES}
+    do
+        if [ "${f##*.}" == 'conf' ]; then continue; fi
+        echo "${f}"
+        clang-tidy -p "${BUILD_DIR}" "${CHECKS}" -header-filter="^$(pwd).*" "${f}"
+       done
+fi
+
+# H/HPP do not have a compile command
+# workaround: add the includes
+if [ ${#MODIFIED_HEADERS[@]} != 0 ] ; then
+    for f in ${MODIFIED_HEADERS}
+    do
+        echo "${f}"
+        clang-tidy "${CHECKS}" -header-filter=.* "${f}" \
+            -- -I./include -isystem "${POSTGRES_SERVER}"
+    done
+fi

.github/workflows/boost_version.yml

@@ -18,12 +18,17 @@ name: Boost supported versions
 # Currently
 # - boost::geometry has not changed anything we use
 #
-# - boost::graph changed on 1.80
-# - boost::graph 1.75 requires C++14
-# - boost::graph changed on 1.68
-# - 1.56 is the minimum version we ask
+# boost::graph
+# - 1.86 does not support C++11 (Aug 2024)
+# - 1.84 is failing its own tests (Jul 2022)
+# - 1.83 transitive closure & stoer wagner changed on 83 (Jul 2022)
+# - 1.80 changed on 1.80 (Aug 2022)
+# - 1.75 requires C++14 (Dec 2020)
+# - 1.68 changed on 1.68 (Aug 2018)
+# - 1.56 is the minimum version we ask (Aug 2014)
 
 on:
+  workflow_dispatch:
   push:
     paths:
       - '.github/workflows/boost_version.yml'
@@ -65,7 +70,7 @@ jobs:
     strategy:
         fail-fast: false
         matrix:
-          boost_minor: [56, 68, 75]
+          boost_minor: [56, 68, 75, 76, 77, 78, 79, 80, 83, 84, 86]
 
     steps:
       - uses: actions/checkout@v4
@@ -91,11 +96,6 @@ jobs:
           sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt/ \
             $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
 
-      - name: Install python
-        uses: actions/setup-python@v4
-        with:
-          python-version: '3.x'
-
       - name: Install dependencies
         run: |
           sudo apt-get update
@@ -107,8 +107,6 @@ jobs:
             postgresql-${PGVER}-postgis-${PGIS}-scripts \
             postgresql-server-dev-${PGVER}
 
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt
           wget https://sourceforge.net/projects/boost/files/boost/1.${{ matrix.boost_minor }}.0/boost_1_${{ matrix.boost_minor }}_0.tar.bz2
           #wget https://dl.bintray.com/boostorg/release/1.${{ matrix.boost_minor }}.0/source/boost_1_${{ matrix.boost_minor }}_0.tar.bz2
           sudo tar --bzip2 -xf  boost_1_${{ matrix.boost_minor }}_0.tar.bz2
@@ -120,7 +118,7 @@ jobs:
           export PATH=/usr/lib/postgresql/${PGVER}/bin:$PATH
           mkdir build
           cd build
-          cmake -DPOSTGRESQL_VERSION=${PGVER} -DCMAKE_BUILD_TYPE=Debug -DWITH_DOC=OFF ..
+          cmake -DPOSTGRESQL_VERSION=${PGVER} -DCMAKE_BUILD_TYPE=Debug ..
 
       - name: Build
         run: |
@@ -133,5 +131,5 @@ jobs:
           sudo service postgresql start
           psql -c "CREATE DATABASE ___pgr___test___;"
           DIR=$(git rev-parse --show-toplevel)
-          bash "${DIR}/tools/testers/setup_db.sh" "${PGPORT}" ___pgr___test___ "${PG_RUNNER_USER}" "3.6.0"
+          bash "${DIR}/tools/testers/setup_db.sh" "${PGPORT}" ___pgr___test___ "${PG_RUNNER_USER}" "3.7.0"
           pg_prove  -Q -f --normalize --directives --recurse -U "${PG_RUNNER_USER}" -d ___pgr___test___ "pgtap"

.github/workflows/centos.yml

@@ -32,7 +32,7 @@ jobs:
       - centos-7 gcc-4.8.5
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: get postgres version
         run: |

.github/workflows/check-files.yml

@@ -33,8 +33,8 @@ jobs:
       - name: News file up to date
         run: |
           tools/release-scripts/notes2news.pl
-          if git status | grep 'NEWS'; then echo "NEWS is not up to date"; exit 1; fi
-          if ! grep -q $(grep -Po '(?<=project\(PGROUTING VERSION )[^;]+' CMakeLists.txt) NEWS; then echo "Missing section in NEWS"; exit 1; fi
+          if git status | grep 'NEWS.md'; then echo "NEWS.md is not up to date"; exit 1; fi
+          if ! grep -q $(grep -Po '(?<=project\(PGROUTING VERSION )[^;]+' CMakeLists.txt) NEWS.md; then echo "Missing section in NEWS.md"; exit 1; fi
 
   License_check:
     runs-on: ubuntu-latest

.github/workflows/check-queries.yml

@@ -12,6 +12,7 @@ name: Check queries
 # - the latest postgis version
 
 on:
+  workflow_dispatch:
   push:
     paths:
       - '.github/workflows/check-queries.yml'
@@ -110,10 +111,13 @@ jobs:
       - name: Test documentation queries are up to date
         run: |
           sudo -u postgres createdb -p ${PGPORT}  pgr_test__db__test
-          TESTDIRS="version"
+          # queries that might change
+          # version: will catch the current version
+          # mincut: results change depending on boost
+          TESTDIRS="version mincut"
           for d in ${TESTDIRS}
           do
-            ./tools/testers/doc_queries_generator.pl -pgver "${PGVER}" -pguser runner -documentation -alg "${d}"
+            ./tools/testers/doc_queries_generator.pl -pgver "${PGVER}" -pguser runner -documentation -alg "docqueries/${d}"
           done
 
           ./tools/testers/doc_queries_generator.pl -pgver "${PGVER}"

.github/workflows/clang.yml

@@ -11,6 +11,7 @@ name: Build for Ubuntu with clang
 # - postgis 3
 
 on:
+  workflow_dispatch:
   push:
     paths:
       - '.github/workflows/clang.yml'

.github/workflows/doc-check.yml

@@ -52,7 +52,7 @@ jobs:
     strategy:
         fail-fast: false
         matrix:
-          language: [en,es]
+          language: [en,es,zh_Hans]
 
     steps:
       - uses: actions/checkout@v4
@@ -93,7 +93,7 @@ jobs:
 
       - name: Install python
         if: env.PROCESS == 'true'
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: '3.x'
 
@@ -119,7 +119,7 @@ jobs:
           mkdir build
           cd build
           cmake -DLINKCHECK=ON -DWITH_DOC=ON \
-                -DES=ON -DBUILD_DOXY=ON \
+                -DES=ON -DZH_HANS=ON -DBUILD_DOXY=ON \
                 -DPOSTGRESQL_VERSION=${PGVER} -DCMAKE_BUILD_TYPE=Release ..
 
       - name: Check Documentation

.github/workflows/macos.yml

@@ -5,6 +5,31 @@ name: Build for macOS
 
 on:
   workflow_dispatch:
+  push:
+    paths:
+      - '.github/workflows/macos.yml'
+      - 'src/**'
+      - 'include/**'
+      - 'pgtap/**'
+      - 'tools/testers/**'
+      - './CMakeLists.txt'
+
+    branches-ignore:
+      - 'gh-pages'
+
+    tags: []
+
+  pull_request:
+    paths:
+      - '.github/workflows/macos.yml'
+      - 'src/**'
+      - 'include/**'
+      - 'pgtap/**'
+      - 'tools/testers/**'
+      - './CMakeLists.txt'
+
+    branches-ignore:
+      - 'gh-pages'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -16,15 +41,20 @@ permissions:
 jobs:
   build:
     name: macos
-    runs-on: macos-latest
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [macos-latest, macos-14]
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
       - name: install deps
         run: |
-          brew install postgresql postgis boost
+          brew install postgresql@14 postgis boost
 
       - name: Configure
         run: |
@@ -36,22 +66,21 @@ jobs:
         run: |
           cd build
           make -j
-          sudo make install
+          make install
 
       - name: Install pgTAP
         run: |
           git clone https://github.com/theory/pgtap.git pgTapExtension
           cd pgTapExtension
           make -j
-          sudo make install
-          sudo cpan TAP::Parser::SourceHandler::pgTAP
-          sudo find /usr/local -name pg_prove
-          sudo ln -s  /usr/local/Cellar/perl/5.32.1_1/bin/pg_prove  symlink it into /usr/local/bin
+          make install
+          cpan TAP::Parser::SourceHandler::pgTAP
+          ln -s $(find `brew --prefix` -name pg_prove) symlink it into $(brew --prefix)/bin
 
       - name: Test
         run: |
-          export PATH=/usr/local/Cellar/perl/$(perl -e 'print substr($^V, 1)')/bin:$PATH
-          pg_ctl -D /usr/local/var/postgres start
+          export PATH=$(brew --prefix)/Cellar/perl/$(perl -e 'print substr($^V, 1)')/bin:$PATH
+          pg_ctl -D $(brew --prefix)/var/postgresql@14 start
           createuser -s postgres
           createdb ___pgr___test___
           bash ./tools/testers/pg_prove_tests.sh postgres 5432 Release