Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pgr line graph #2625

Merged
merged 12 commits into from
May 13, 2024
Merged

Fix pgr line graph #2625

merged 12 commits into from
May 13, 2024

Conversation

cvvergara
Copy link
Member

@cvvergara cvvergara commented Feb 26, 2024 •
edited
Loading

Fixes #2564

Changes proposed in this pull request:

  • Rewrite code for pgr_lineGraph
  • refine tidy-vs-commit.sh to not process .conf files
  • Modify change log and NEWS
  • Vote for promotion to proposed

@pgRouting/admins

@cvvergara cvvergara added this to the Release 3.7.0 milestone Feb 26, 2024
@cvvergara cvvergara marked this pull request as draft February 26, 2024 19:20
@cvvergara cvvergara mentioned this pull request May 7, 2024
Merged
@cvvergara cvvergara added the Vote Needed When promoting experimental->proposed->official label May 9, 2024
@cvvergara
Copy link
Member Author

VOTE

With this PR pgr_lineGraph:

  • issues are fixed
  • Additional pgtap tests are added
  • Documentation has been refined
  • C/C++ Code has been cleaned/rewritten
  • Includes the documentation change for the promotion to proposed

We require at least 5 votes to promote the function pgr_lineGraph from experimental to proposed
Please give your thumbs up/down in this comment as way to vote.

@cvvergara cvvergara marked this pull request as ready for review May 9, 2024 17:07
@cvvergara cvvergara merged commit 8582944 into pgRouting:develop May 13, 2024
23 of 24 checks passed
@cvvergara cvvergara deleted the fix-pgr_lineGraph branch May 13, 2024 17:20
@cvvergara cvvergara mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robe2 robe2 robe2 approved these changes

@dkastl dkastl Awaiting requested review from dkastl

@sanak sanak Awaiting requested review from sanak

@cayetanobv cayetanobv Awaiting requested review from cayetanobv

@omshinde omshinde Awaiting requested review from omshinde

@iosefa iosefa Awaiting requested review from iosefa

@krashish8 krashish8 Awaiting requested review from krashish8

Assignees
No one assigned
Labels
Bug Fix Vote Needed When promoting experimental->proposed->official
Projects
None yet
Milestone
Release 3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cvvergara @robe2