feat; Nickname is now display on the exercise-list and can be changed #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…learn-ocaml-client server-config
…f use_password is true
…ig from the client to finish the authentication with login and password
…t for the learn-ocaml-client server-config
* Remove .travis.yml as well
…ing in with bad combo or when grading syntax error or other errors
… instead of shell command to string in order to avoid shell code injection
… shell-command-to-string
…command-to-string
…h remove the entire file cookie
…n by server-config instead of the boolean
* Merge learn-ocaml-error-handler-sign-in and learn-ocaml-error-handler-sign-up to learn-ocaml-error-handler-nosplit-catch * Document the workflow for authenticating (sign-up/login)
* Add more doc-comments * Add two "FIXME(Bug)" [learn-ocaml-error-handler, $ learn-ocaml-client deinit]
Summary: * Update Makefile to also provide: $ make back # Run a docker backend for interactive ERT tests $ make emacs # Run a dockerized emacs for ERT tests $ make tests # Run dockerized ERT tests $ make stop # Stop the docker backend and/or ERT frontend $ make dist-tests # Alias-of: make back emacs tests $ make dist-tests USE_PASSWD=true * Split-remove test.sh * Add four different scripts: - run_test_backend.sh - run_emacs_image.sh - run_tests.sh - stop_emacs_image.sh - stop_test_backend.sh * Update tests/README.md * Update GHA Note however that the ERT layer still needs some update. Yet, it will be able to benefit from these two files: - confirm.txt - teacher.txt (containing useful but hidden, (docker-logs)-provided information).
* This is needed as the `*.sh` scripts don't have `set -e` currently.
In order to have await-for cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.