Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for node to report address before removing taint #2

Closed
wants to merge 3 commits into from
Closed

wait for node to report address before removing taint #2

wants to merge 3 commits into from
+405 −61

Conversation

huwcbjones
Copy link

  • address/assigner: return assigned address
  • cmd/assignAddress: return assignedAddress
  • cmd/run: wait for address to be reported before removing taint

w-miller
w-miller reviewed Oct 31, 2024
View reviewed changes
Copy link

@w-miller w-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but overall looks reasonable to me!

cmd/main.go Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
cmd/main_test.go Show resolved Hide resolved
internal/address/gcp.go Show resolved Hide resolved
@huwcbjones huwcbjones force-pushed the huw/taint-wait-for-report branch from c84de32 to e0f2d7c Compare November 4, 2024 12:51
@huwcbjones
Copy link
Author

Superseded by doitintl#158

@huwcbjones huwcbjones closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-miller w-miller w-miller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huwcbjones @w-miller