Update theme #231
Merged
Update theme #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fflaten
commented
Aug 10, 2022
fflaten
commented
- Improve contrast, especially in dark mode (related Low contrast ratio #221)
- Limit overflow to table in v5 migration guide (fix Horizontal overflow in migration guide #224)
- Update styling in navbar (fix Dark navigation-text in hamburger menu (mobile) while in light mode #222)
|
Active section link + hover used a color in both modes: However the color disappears after moving to another page in the same section, so I removed it (now always white). Added underline on hover to have some type of effect but can't decide if I like it. Thoughts? |
|
Less is more, I like it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.