Upgrade to Upstream rosbridge
and roslibjs
#125
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this pull request. Link to relevant GitHub issues, if any.
In service of #97 . This PR was developed and tested with the latest version of roslibjs and rosbridge's source code. Everything worked but action cancellation, which is due to an issue in when rosbridge considers the "send_action_goal" operation to be done.
I'm leaving this PR a draft, until the above issue is addressed.
Explain how this pull request was tested, including but not limited to the below checkmarks.
[TODO]
Before creating a pull request
npm run format
python3 -m black .
in the top-level of this repositoryBefore merging a pull request
Squash and Merge
)