Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Upstream rosbridge and roslibjs #125

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amalnanavati
Copy link
Contributor

Describe this pull request. Link to relevant GitHub issues, if any.

In service of #97 . This PR was developed and tested with the latest version of roslibjs and rosbridge's source code. Everything worked but action cancellation, which is due to an issue in when rosbridge considers the "send_action_goal" operation to be done.

I'm leaving this PR a draft, until the above issue is addressed.

Explain how this pull request was tested, including but not limited to the below checkmarks.

[TODO]


Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati marked this pull request as draft February 19, 2024 23:44
@amalnanavati amalnanavati linked an issue Feb 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rosbridge_suite and roslibjs
1 participant