Fix next, previous, first, and last bugs in document Link header #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2019
Fix a few bugs in the `Fragment#*_fragment` methods. These bugs manifested themselves in the `Link` header of the `/documents` endpoints. * Do not include `parent: parent` in the `where` clauses; the last fragment should be the last one in the entire text not in the book/chapter/etc. * Use `> rank` and `< rank` instead of `rank: rank + 1` and `rank: rank - 1`; sometimes the next or previous fragment is separated by a distance greater than `1`. * Add missing method tests in `Fragment`.
zfletch
force-pushed
the
rel-prev-next-absolute
branch
from
64893ef to
f56e204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few bugs in the
Fragment#*_fragmentmethods. These bugs were pointed out by @balmas in point 5 in her comment here.parent: parentin thewhereclauses; the last fragment should be the last one in the entire text not in the book/chapter/etc.> rankand< rankinstead ofrank: rank + 1andrank: rank - 1; sometimes the next or previous fragment is separated by a distance greater than1.