Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom 3rd-party authentication. #50

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bokysan
Copy link

@bokysan bokysan commented Aug 10, 2016

Hi,

since I couldn't find a plugin for this, I've fixed yours -- I've added support for a custom 3rd-party OAuth2 provider.

In my case, I needed Wordpress to authenticate against Keycloak.

To the best of my knowledge, integration works.

The plugin now has the following features:
- It's possible to use a 3rd-party OAuth provider. Additional
  configuration has been added to configure the details
- It's possible to link all 3rd-party logins to the same Wordpress user.
  Especially useful if you only need to have the users logged in but
  don't care much about their identities (e.g. useful if you use a
  plugin such as "Force Login")
- If there's only one provider defined *AND* you disable the default
  login form of Wordpress, the user will be automatically redirected to
  this provider. This esentially eliminates the Wordpress login page and
  relies on the 3rd-party provider only. For example, if you enable only
  Facebook, clicking on "Login" will take the user directly to Facebook
  "authorize application" page.
- Lots of small fixes; e.g.:
  - admin page now has full width input boxes, which make long URLs
    much easier to handle;
  - custom login relies on wp_remote_get() instead of curl(), so it
    works even if the CURL library is not installed / linked with PHP


<!-- START Login with Custom OAuth provider section -->
<div id="wpoa-settings-section-login-with-battlenet" class="wpoa-settings-section">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id should be wpoa-settings-section-login-with-custom.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste. Fixed.

B

@smikkelsen
Copy link

This is exactly what I was looking for. Looks like there are no conflicts, will this be merged anytime soon?

cguethle added a commit to cguethle/WP-OAuth that referenced this pull request Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants