Move Configuration to separate module #798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ileitch What do you think about scheme for public API use? |
rofle100lvl
force-pushed
the
SeparateConfiguration
branch
2 times, most recently
from
b95995a to
e8a599e
Compare
|
@ileitch Can you check it? New and new conflicts will appear. And also I have a talk in october and by this time i really want to move my project from fork to spm dependency... |
|
I've implemented this in #817 as I took a slightly different approach, but thanks for the contribution all the same! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to separate Configuration and here is why.
First of all, it's a big piece of logic. And it should be well separated. Also I'm planning to make it start point in public API. So the scheme would be like that:
User -> Setup Configuration -> Launch ProjectDriver to the project -> Got SourceGraph and can analyze anything he wants.
For that purpose Configuration should be separated in different module. Because of that, Its needed to make some moves around (because cycling dependencies)
BaseLogger -> SeparatedModule
Logger, Glob, Shell, SwiftVersion, SwiftParser -> Utils
Configuration -> SeparatedModule