Add dynamic ports for 8000 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
To configure the MQTT port we need unixorn/ha-mqtt-discoverable#91 |
|
ah i see, not possible for the moment then |
|
But if i use the addon condig, to define a manual broker, then i can setup a port , how come its not possible when its running as standalone container? |
pergolafabio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @mion00 , created this PR, can you have a look?
Added optional port for hikvisin devices, for users not using 8000 => i think this one is OK
Added option for docker users to define an mqtt port, default is 1883 now, but for some reason, if i change in my environment like below "9999", it still uses "1883" , somewhere its still hardcoded?