Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12451 MongoDB Explain - V3 #3166

Merged
merged 2 commits into from
Aug 21, 2024
Merged

PMM-12451 MongoDB Explain - V3 #3166

merged 2 commits into from
Aug 21, 2024

Conversation

JiriCtvrtka
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka commented Aug 21, 2024

PR to merge it into V3.

V2 PR: #3152 (merged)
Ticket: https://perconadev.atlassian.net/browse/PMM-12451

* PMM-12451 Todo.

* PMM-12451 Changes.

* PMM-12451 Version check, refactor.

* PMM-12451 Remove Mongo < 4.0.0 compatibility and logic.

* PMM-12451 Remove unused annotations.

* PMM-12451 Make format.

* PMM-12451 Lint.

* PMM-12451 Lint.

* PMM-12451 Downgrade driver.

* PMM-12451 Changes.

* PMM-12451 Old tests.

* PMM-12451 Test.

* Revert "PMM-12451 Old tests."

This reverts commit feb3721.

* Revert "PMM-12451 Test."

This reverts commit acf12a7.

* PMM-12451 Changes.

* PMM-12451 Lint.

* PMM-12451 Fix wrong version number in comment.

* PMM-12451 Remove lsid.

* PMM-12451 Test with 1.16.1 driver.

* PMM-12451 Unmarshal canonical to false.

* Reapply "PMM-12451 Old tests."

This reverts commit a5754c8.

* Revert "PMM-12451 Test."

This reverts commit acf12a7.

* PMM-12451 Return back removeDBField after canonical false.

* PMM-12451 Remove rest of lsids in tests.

* PMM-12451 Fix comment.

* PMM-12451 Handle not supported commands.

* PMM-12451 Refactor.

* PMM-12451 Fix logic for OriginatingCommand.

* PMM-12451 Small test refactor.

* Update agent/runner/actions/mongodb_explain_action.go

Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-12451 Required changes.

* PMM-12451 Adds release notes.

* PMM-12451 Add comments to unclear places.

* PMM-12451 Changes in comments.

* PMM-12451 Add PMM-13017 and PMM-13071 to RN.

* Update docs/release-notes/2.43.0.md

Co-authored-by: Catalina A <[email protected]>

* Update docs/release-notes/2.43.0.md

Co-authored-by: Catalina A <[email protected]>

* Update agent/runner/actions/mongodb_explain_action.go

Co-authored-by: Alex Demidoff <[email protected]>

* PMM-12451 Improvement to handle dbstats command.

* PMM-12451 Fix RN after applied suggestion.

---------

Co-authored-by: Nurlan Moldomurov <[email protected]>
Co-authored-by: Catalina A <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review August 21, 2024 11:56
@JiriCtvrtka JiriCtvrtka requested review from a team as code owners August 21, 2024 11:56
@JiriCtvrtka JiriCtvrtka enabled auto-merge (squash) August 21, 2024 11:56
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 58.06452% with 39 lines in your changes missing coverage. Please review.

Project coverage is 44.61%. Comparing base (0be6f30) to head (954f70b).
Report is 1 commits behind head on v3.

Files Patch % Lines
agent/runner/actions/mongodb_explain_action.go 58.06% 35 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3166      +/-   ##
==========================================
+ Coverage   44.55%   44.61%   +0.06%     
==========================================
  Files         357      357              
  Lines       35577    35661      +84     
==========================================
+ Hits        15852    15911      +59     
- Misses      18103    18127      +24     
- Partials     1622     1623       +1     
Flag Coverage Δ
admin 11.47% <ø> (-0.06%) ⬇️
agent 52.79% <58.06%> (+0.18%) ⬆️
managed 46.76% <ø> (ø)
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JiriCtvrtka JiriCtvrtka merged commit 0a4e947 into v3 Aug 21, 2024
29 checks passed
@JiriCtvrtka JiriCtvrtka deleted the PMM-12451-mongo-explain-v3 branch August 21, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants