PMM-7 Update pg_query_go #2965
Open
PMM-7 Update pg_query_go #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
ademidoff and
idoqo
and removed request for
a team
BupycHuk
commented
Apr 18, 2024
Comment on lines
2
to
7
| "error": "error on parsing sql query: subquery in FROM must have an alias" | ||
| "tables": [ | ||
| "credit_card_wo_complaints", | ||
| "without_complaints" | ||
| ], | ||
| "error": "" | ||
| } |
There was a problem hiding this comment.
query by itself is incorrect but I see no harm in extracting tables from incorrect query
JiriCtvrtka
approved these changes
Apr 22, 2024
idoqo
approved these changes
Apr 23, 2024
.github/workflows/agent.yml
Outdated
| - { mysql: 'mariadb:10.3', mongo: 'percona/percona-server-mongodb:4.4', postgres: 'postgres:9.5', pmm_server: 'perconalab/pmm-server:dev-latest' } | ||
| - { mysql: 'mariadb:10.4', postgres: 'postgres:9.6', pmm_server: 'perconalab/pmm-server:dev-latest' } | ||
| - { mysql: 'mariadb:10.2', mongo: 'mongo:4.4', postgres: 'postgres:10', pmm_server: 'perconalab/pmm-server:dev-latest' } | ||
| - { mysql: 'mariadb:10.3', mongo: 'percona/percona-server-mongodb:4.4', postgres: 'postgres:11', pmm_server: 'perconalab/pmm-server:dev-latest' } |
There was a problem hiding this comment.
curious why we dropped the minor versions though (e.g testing on 10.x)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #2965 +/- ##
==========================================
- Coverage 44.77% 44.51% -0.26%
==========================================
Files 360 360
Lines 36153 36156 +3
==========================================
- Hits 16186 16095 -91
- Misses 18305 18406 +101
+ Partials 1662 1655 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@BupycHuk |
ademidoff
force-pushed
the
v3
branch
3 times, most recently
from
8421bc2
to
da25a0c
Compare
ademidoff
force-pushed
the
v3
branch
2 times, most recently
from
4b06c24
to
6a7efaf
Compare
| "winningPlan": map[string]interface{}{"stage": "EOF"}, | ||
| } | ||
| mongoDBVersion := tests.MongoDBVersion(t, client) | ||
| fmt.Printf("MongoDB version: %s\n", mongoDBVersion) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
use of fmt.Printf forbidden by pattern ^(fmt\.Print(|f|ln)|print|println)$ (forbidigo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: