-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12896 Add limit for actions/jobs executed on the same DB at the same time #2898
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
==========================================
- Coverage 43.28% 41.80% -1.48%
==========================================
Files 399 397 -2
Lines 41394 48489 +7095
==========================================
+ Hits 17916 20272 +2356
- Misses 21477 26213 +4736
- Partials 2001 2004 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to limit connections for any other DB types except PostgreSQL? Does it affect other DBs the same way as it does for PostgreSQL. I'm affraid of doing more harm then providing advantage with these changes.
This reverts commit 477790b.
MySQL and MongoDB don't have such problems with connections as PostgreSQL, but it may be still an issue. For example MySQL by default allows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
PMM-12896
Link to the Feature Build: SUBMODULES-3588