Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 #2890

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2024

Bumps github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0.

Release notes

Sourced from github.com/go-sql-driver/mysql's releases.

v1.8.0

What's Changed

Major changes

  • Use SET NAMES charset COLLATE collation. by @​methane in go-sql-driver/mysql#1437

    • Older go-mysql-driver used collation_id in the handshake packet. But it caused collation mismatch in some situation.
    • If you don't specify charset nor collation, go-mysql-driver sends SET NAMES utf8mb4 for new connection. This uses server's default collation for utf8mb4.
    • If you specify charset, go-mysql-driver sends SET NAMES <charset>. This uses the server's default collation for <charset>.
    • If you specify collation and/or charset, go-mysql-driver sends SET NAMES charset COLLATE collation.
  • PathEscape dbname in DSN. by @​methane in go-sql-driver/mysql#1432

    • This is backward incompatible in rare case. Check your DSN.
  • Drop Go 1.13-17 support by @​methane in go-sql-driver/mysql#1420

    • Use Go 1.18+
  • Parse numbers on text protocol too by @​methane in go-sql-driver/mysql#1452

    • When text protocol is used, go-mysql-driver passed bare []byte to database/sql for avoid unnecessary allocation and conversion.
    • If user specified *any to Scan(), database/sql passed the []byte into the target variabe.
    • This confused users because most user doesn't know when text/binary protocol used.
    • go-mysql-driver 1.8 converts integer/float values into int64/double even in text protocol. This doesn't increase allocation compared to []byte and conversion cost is negilible.
  • New options start using the Functional Option Pattern to avoid increasing technical debt in the Config object. Future version may introduce Functional Option for existing options, but not for now.

Other changes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner March 12, 2024 02:32
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 12, 2024
@dependabot dependabot bot requested a review from a team as a code owner March 12, 2024 02:32
@dependabot dependabot bot added the go Pull requests that update Go code label Mar 12, 2024
@dependabot dependabot bot requested review from ademidoff, BupycHuk, idoqo and JiriCtvrtka and removed request for a team March 12, 2024 02:32
@github-actions github-actions bot enabled auto-merge (squash) March 12, 2024 02:32
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.27%. Comparing base (8ae32f5) to head (b850a04).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2890   +/-   ##
=======================================
  Coverage   42.27%   42.27%           
=======================================
  Files         396      396           
  Lines       50123    50123           
=======================================
  Hits        21188    21188           
  Misses      26932    26932           
  Partials     2003     2003           
Flag Coverage Δ
managed 42.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch 2 times, most recently from 13055f6 to ea4c25c Compare March 13, 2024 10:53
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch from ea4c25c to 9824d85 Compare March 20, 2024 18:08
Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.7.1 to 1.8.0.
- [Release notes](https://github.com/go-sql-driver/mysql/releases)
- [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md)
- [Commits](go-sql-driver/mysql@v1.7.1...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/go-sql-driver/mysql
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch from 9824d85 to b850a04 Compare March 21, 2024 10:57
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 27, 2024

Superseded by #2932.

@dependabot dependabot bot closed this Mar 27, 2024
auto-merge was automatically disabled March 27, 2024 03:00

Pull request was closed

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch March 27, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants