-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12895 Add metrics resolutions configuration to agents #2882
PMM-12895 Add metrics resolutions configuration to agents #2882
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2882 +/- ##
==========================================
- Coverage 43.34% 43.29% -0.06%
==========================================
Files 399 399
Lines 41516 41429 -87
==========================================
- Hits 17996 17937 -59
+ Misses 21514 21488 -26
+ Partials 2006 2004 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was the reason to update descriptor.bin? Does that mean that we introduced some backward-incompatible change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we add a new test to scrape_configs_test with custom metrics resolution?
Functions from |
PMM-12895
Link to the Feature Build: SUBMODULES-3578
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: