PMM-12899 Use module and build cache for PMM Client #2871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2871 +/- ##
==========================================
- Coverage 42.27% 42.27% -0.01%
==========================================
Files 396 396
Lines 50122 50123 +1
==========================================
Hits 21188 21188
- Misses 26931 26932 +1
Partials 2003 2003
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
force-pushed
the
PMM-12899-use-module-and-build-cache
branch
from
34ddc26
to
6052a6e
Compare
|
@pmmbot rebuild |
ademidoff
force-pushed
the
PMM-12899-use-module-and-build-cache
branch
from
563e7a3
to
224eefe
Compare
ademidoff
commented
Mar 17, 2024
build/scripts/build-client-packages
Outdated
| @@ -481,8 +490,6 @@ if [ "$TARBALL" = '1' -o "$SOURCE" = '1' ]; then | |||
| fi | |||
|
|
|||
| check_workdir | |||
| get_system | |||
There was a problem hiding this comment.
These two functions already get executed a few lines above.
build/scripts/build-client-source
Outdated
| fi | ||
| } | ||
|
|
||
| main() { | ||
| rm -rf ${source_tarball} | ||
| mkdir -p ${source_dir}/ $(dirname ${source_tarball}) || : | ||
| echo "PMM_SUBMODULES_COMMIT=$(git rev-parse --short HEAD)" > ${client_properties} |
ademidoff
force-pushed
the
PMM-12899-use-module-and-build-cache
branch
from
653b5a8
to
00a7c96
Compare
ademidoff
commented
Mar 17, 2024
.github/workflows/main.yml
Outdated
| @@ -143,8 +143,8 @@ jobs: | |||
| env: | |||
| SLACK_WEBHOOK: ${{ secrets.SLACK_TOKEN_PMM_CI }} | |||
| SLACK_CHANNEL: "pmm-ci" | |||
| SLACK_USERNAME: "PR pipelines bot" | |||
| SLACK_ICON_EMOJI: ":chestnut:" | |||
There was a problem hiding this comment.
Sorry, I couldn't resist - octocat seems to be a bit more to the point here :)
ademidoff
force-pushed
the
PMM-12899-use-module-and-build-cache
branch
from
00a7c96
to
e8a918e
Compare
ademidoff
commented
Mar 17, 2024
build/scripts/build-client-packages
Outdated
| @@ -133,7 +131,6 @@ get_sources(){ | |||
| echo "MongoExp_BRANCH_NAME=${MongoExp_BRANCH_NAME}" >> $VERSION_FILE | |||
| echo "MysqlExp_BRANCH_NAME=${MysqlExp_BRANCH_NAME}" >> $VERSION_FILE | |||
| echo "ProxysqlExp_BRANCH_NAME=${ProxysqlExp_BRANCH_NAME}" >> $VERSION_FILE | |||
| echo "QAN_BRANCH_NAME=${QAN_BRANCH_NAME}" >> $VERSION_FILE | |||
There was a problem hiding this comment.
These removed variables were not used at all.
ademidoff
force-pushed
the
PMM-12899-use-module-and-build-cache
branch
2 times, most recently
from
ed6ea92
to
bb728ea
Compare
ademidoff
force-pushed
the
PMM-12899-use-module-and-build-cache
branch
from
bb728ea
to
4879e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12899
Link to the Feature Build: SUBMODULES-3589