PMM-13054 minor cleanup

.github/workflows/managed.yml

@@ -43,6 +43,7 @@ jobs:
       - name: Launch PMM Server (see docker-compose.yml)
         run: |
           make env-compose-up # the container workdir is /root/go/src/github.com/percona/pmm
+          docker exec -t pmm-server id -Z || :
           docker logs pmm-server
 
       - name: Mark the root directory of pmm as safe
@@ -120,7 +121,8 @@ jobs:
           docker exec pmm-server go env | sort
           docker exec pmm-server supervisorctl status || true
           services=$(docker exec pmm-server supervisorctl status | awk '{print $1}')
-          while IFS= read -r service; do
+          services=(`echo ${services}`)
+          for service in "${services[@]}"; do
             echo "Logs for $service:"
             docker exec pmm-server supervisorctl tail $service
-          done <<< "$services"
+          done

api-tests/server/auth_test.go

@@ -500,10 +500,8 @@ func TestServiceAccountPermissions(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			for _, user := range test.userCase {
-				user := user
 				t.Run(fmt.Sprintf("Service Token auth %s", user.userType), func(t *testing.T) {
 					// make a BaseURL without authentication
 					u, err := url.Parse(pmmapitests.BaseURL.String())

managed/services/grafana/auth_server.go

@@ -77,12 +77,8 @@ var rules = map[string]role{
 	"/v1/server/updates:start":        admin,
 	"/v1/server/updates:getStatus":    none, // special token-based auth
 	"/v1/server/settings":             admin,
-	"/v1/platform:connect":            admin,
-	"/v1/platform:disconnect":         admin,
-	"/v1/platform/organization/":      viewer,
-	"/v1/platform/contact":            viewer,
-	"/v1/platform/server":             viewer,
-	"/v1/platform/user":               viewer,
+	"/v1/platform:":                   admin,
+	"/v1/platform/":                   viewer,
 	"/v1/users":                       viewer,
 
 	// must be available without authentication for health checking