K8SPSMDB-1124: User roles #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inelpandzic
requested review from
hors,
tplavcic,
nmarukovich,
ptankov,
jvpasinatto and
eleo007
as code owners
jvpasinatto
requested changes
Sep 20, 2024
| @@ -499,6 +499,40 @@ sharding: | |||
| # - name: dbOwner | |||
| # db: sometest | |||
|
|
|||
| # roles: | |||
There was a problem hiding this comment.
Please, add the corresponding crd under psmdb-operator/crds
charts/psmdb-db/README.md
Outdated
| | `roles.authenticationRestrictions.clientSource` | Array of IP addresses or CIDR blocks from which users assigned this role can connect.MongoDB servers reject connection requests from users with this role if the requests come from a client that is not present in this array. | `""` | | ||
| | `roles.authenticationRestrictions.serverAddress` | Array of IP addresses or CIDR blocks to which users assigned this role can connect.MongoDB servers reject connection requests from users with this role if the client requests to connect to a server that is not present in this array. | `""` | | ||
| | `roles.privileges.actions` | Name of the role. Valid values are built-in roles. | `[]` | | ||
| | `spec.roles.privileges.resource.db` | Database for which the privilege `spec.security.roles.privileges.actions` apply. An empty string ("") indicates that the privilege actions apply to all databases. | `""` | |
There was a problem hiding this comment.
Please remove the "spec." prefix in the parameters and descriptions.
Also, just a tip to format the table, try turning word wrap off in your code editor(if you are not doing it yet). The lines are huge, but I hope this will make the table more readable to edit.
jvpasinatto
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
spec.roles.