Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBM-1414 Set Number of Parallel Collections to 1 by default #1041

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

PBM-1414 Set Number of Parallel Collections to 1 by default #1041

wants to merge 9 commits into from

Conversation

radoslawszulgo
Copy link
Collaborator

No description provided.

@defbin
Copy link
Member

defbin commented Oct 30, 2024

maybe here https://github.com/percona/percona-backup-mongodb/blob/dev/pbm/snapshot/restore.go#L20

@radoslawszulgo
Copy link
Collaborator Author

maybe here https://github.com/percona/percona-backup-mongodb/blob/dev/pbm/snapshot/restore.go#L20

I'm not sure. I anyway need to declare this variable. I could do it with 0, and then always overwrite with what comes from the configuration. Would it be better?

@defbin
Copy link
Member

defbin commented Oct 30, 2024

I meant, the request is about changing --numInsertionWorkersPerCollection to 1 (instead of 10). But your PR changes --numParallelCollections

@boris-ilijic
Copy link
Member

In addition by ticket requirement, the same parameter should be exposed as an option of restore command (e.g. --num-insertion-workers) which would override currently only available config parameter: restore.numInsertionWorkers
https://docs.percona.com/percona-backup-mongodb/reference/restore-options.html#restorenuminsertionworkers

radoslawszulgo and others added 5 commits October 31, 2024 13:16
@radoslawszulgo
revert change and adjust numInsertionWorkersDefault to from 10 to 1
8d47d0b
@radoslawszulgo
Add an option to pass numInsertionWorkersPerCol from command line and…
f7c8ecf 
… from config file
@radoslawszulgo
Fix warnings and long code lines
10205ab
@radoslawszulgo @github-actions
fix formatting pbm/restore/logical.go
3faa9b8 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@radoslawszulgo @github-actions
fix formatting pbm/snapshot/restore.go
fafc6f5 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
defbin
defbin reviewed Nov 6, 2024
View reviewed changes
cmd/pbm/main.go Show resolved Hide resolved
pbm/restore/logical.go Outdated Show resolved Hide resolved
pbm/restore/logical.go Outdated Show resolved Hide resolved
radoslawszulgo and others added 2 commits November 6, 2024 19:02
@radoslawszulgo @defbin
Apply suggestions from code review
95a3454 
fix formatting and add a default value to help

Co-authored-by: Dmytro Zghoba <[email protected]>
@defbin @github-actions
Update pbm/restore/logical.go
179c819 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defbin defbin defbin approved these changes

@boris-ilijic boris-ilijic boris-ilijic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radoslawszulgo @defbin @boris-ilijic