Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type definitions #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martinussuherman
Copy link
Contributor

@perarnborg as I've promised, here they are, feel free to suggest changes.

Regards,

Martinus

- Update imports
- Add interface VuexOidcRouteMeta and VuexOidcRoute
- Add type VuexOidcRouteConfig
- Change Route to VuexOidcRoute
- Change RouteConfig to VuexOidcRouteConfig
- Use Promise<T> as return type for async functions in VuexOidcStoreActions
- Change vuexOidcCreateRouterMiddleware return type to NavigationGuard<Vue>
- Change oidcUser return type to Profile
Copy link
Owner

@perarnborg perarnborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for responding so late.

This looks great to me! Just one question from me in a line comment.

import { ActionContext, Module, Store } from 'vuex';
import { OidcClientSettings, User, UserManager } from 'oidc-client';
import { Route, RouteConfig } from 'vue-router';
import Vue from 'vue'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Vue imported here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants