Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure env-vars are handled as strings #84

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

ThomasEcuer
Copy link
Contributor

This avoids suprocess.run to fail ambiguously due to non-string values inherited from configuration
(like postgresql' port number).

Cf. #83.

Successful PR Checklist:

  • Tests
  • Documentation (optionally: run spell checking)
  • Had a good time contributing? (feel free to give some feedback)

This avoids suprocess.run to fail ambiguously due to non-string values inherited from configuration
(like postgresql' port number). Refs #83.
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files          15       15           
  Lines         642      642           
  Branches       81       81           
=======================================
  Hits          505      505           
  Misses        127      127           
  Partials       10       10           
Flag Coverage Δ
#integration 57.78% <100.00%> (ø)
#unit 60.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
septentrion/runner.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb8c8c...7fddcc0. Read the comment docs.

@ewjoachim ewjoachim merged commit 6a04ba9 into master Aug 3, 2020
@ewjoachim ewjoachim deleted the 83-env-vars-must-be-strings branch August 3, 2020 21:29
@ewjoachim
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants