버튼 컴포넌트 디자인 리뉴얼 반영하기 #1579
Merged
버튼 컴포넌트 디자인 리뉴얼 반영하기 #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “:rocket:” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
배포가 끝나면 아래 주소에서 프리뷰를 확인할 수 있어요.
|
mu-hun
force-pushed
the
button-renewal
branch
2 times, most recently
from
2aa327a to
38e5b60
Compare
This was referenced Mar 26, 2024
Seohyun-Roh
requested changes
Mar 26, 2024
Seohyun-Roh
approved these changes
Mar 27, 2024
Merge activity
|
작업하면서 발견한 건데 v2 Button 컴포넌트가 링크로 쓰이는 경우 hover, active 등 인터렉션 스타일 클래스가 누락되네요... 현재 프로덕션 코드 베이스도 포함입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업하면서 발견한 건데 v2 Button 컴포넌트가 링크로 쓰이는 경우 hover, active 등 인터렉션 스타일 클래스가 누락되네요... 현재 프로덕션 코드 베이스도 포함입니다.