ci: add nix env and gha workflows #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
4-ci-skeleton
branch
3 times, most recently
from
2df453d
to
b71542f
Compare
First pass at a dev env, which pulls in the usual Rust deps, as well as go, which is required to build `penumbra-indexer`. The devshell pulls in the necessary deps, resulting in `cargo build` running the proxy build for go via `build.rs` just fine. Not yet supported is `nix build`: will need to figure out a two-pass approach, because network access during the buildPhase is not permitted, so the go build via rust fails. CI cache timing info: * First run of cargo-check: 3m13s * First run of cargo-fmt: 1m57s
conorsch
force-pushed
the
4-ci-skeleton
branch
from
b71542f
to
ded2f0f
Compare
conorsch
commented
Sep 6, 2024
| @@ -301,7 +301,7 @@ mod test { | |||
|
|
|||
| const CHAIN_ID: &'static str = "penumbra-test"; | |||
|
|
|||
| #[tokio::test] | |||
| #[tokio::test(flavor = "multi_thread")] | |||
There was a problem hiding this comment.
The multi_thread annotations were necessary for me to get cargo test passing locally. If you were using a different invocation to force a multithreaded runtime rather than current-thread on the CLI, I'm curious to know it, otherwise I think this is a sane strategy.
There was a problem hiding this comment.
Weird, I just ran cargo test locally with no issues, but that seems like a possibility given SQLX relying on tokio
cronokirby
approved these changes
Sep 6, 2024
|
Thanks a lot for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at a dev env, which pulls in the usual Rust deps, as well as go, which is required to build
penumbra-indexer. The devshell pulls in the necessary deps, resulting incargo buildrunning the proxy build for go viabuild.rsjust fine.Not yet supported is
nix build: will need to figure out a two-pass approach, because network access during the buildPhase is not permitted, so the go build via rust fails.Closes #4.