-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added messageUpdate for counting #11
base: master
Are you sure you want to change the base?
Conversation
mmm yes |
@kognise considering the numerous blockages of the #counting channel, it would be appreciated if you would stop being lazy and merge this! |
@kognise it wouwd be appweciated if you couwd mewge this pwetty pwetty pwease 🥺 <3 |
no |
day 1 of politely asking @kognise to merge my pr: pls merge it pls merge it pls merge it |
this is gonna turn into violence and profanity sooo fast
…On Mon, Oct 18, 2021 at 8:48 PM Andrew ***@***.***> wrote:
day 1 of politely asking @kognise <https://github.com/kognise> to merge
my pr: *pls merge it pls merge it pls merge it*
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKEVYGPCZ7LQSPG33UUSC5TUHS565ANCNFSM4UZ5NP4Q>
.
|
day 2 of praying for @kognise to merge this:
|
you see, incorrect grammar. |
day 3 of annoying @kognise into merging this: |
day 4 of requesting for @kognise to merge this: pls just do it so i can stop this daily thing |
day 5 of asking @kognise to merge this: please do it, so i can stop having a random alarm go off reminding me to send this |
day 6 of pleading for @kognise to merge this: please i almost forgot to send this just merge it pls |
@ajkachnic u missed last night 😢 |
day 8 of reminding @kognise to merge this ( |
I added an
onMessageUpdate
function to the base handler class, and implemented a way to delete updated messages for the counting handler, following this order:A few lines in particular are a little long, especially the
allHandlers
call in theclient.on('messageUpdate')
segment. This might be fine, or I could fix it, but I'm fine with either way