Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added messageUpdate for counting #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajkachnic
Copy link

I added an onMessageUpdate function to the base handler class, and implemented a way to delete updated messages for the counting handler, following this order:

  • Checks if the message is the latest message (if it isn't, it's ignored)
  • Checks that the parsed number in the message has changed (if not, it's ignored)
  • Deletes the message if the previous checks were true

A few lines in particular are a little long, especially the allHandlers call in the client.on('messageUpdate') segment. This might be fine, or I could fix it, but I'm fine with either way

@firefish111
Copy link

mmm yes

@ajkachnic
Copy link
Author

@kognise considering the numerous blockages of the #counting channel, it would be appreciated if you would stop being lazy and merge this!

@ajkachnic
Copy link
Author

@kognise it wouwd be appweciated if you couwd mewge this pwetty pwetty pwease 🥺 <3

@firefish111
Copy link

@kognise it wouwd be appweciated if you couwd mewge this pwetty pwetty pwease pleading_face <3

no

@kognise kognise self-requested a review October 16, 2021 16:58
@ajkachnic
Copy link
Author

day 1 of politely asking @kognise to merge my pr: pls merge it pls merge it pls merge it

@kognise
Copy link
Member

kognise commented Oct 19, 2021 via email

@ajkachnic
Copy link
Author

ajkachnic commented Oct 20, 2021

day 2 of praying for @kognise to merge this:

Dear thy holy kognise, I humbly ask thine to mergeth this request to pulleth. I beg thy holiness to aid in this effort to avoid blockages whilst counting

@firefish111
Copy link

day 2 of praying for @kognise to merge this:

Dear thy holy kognise, I humbly ask thine to mergeth this request to pulleth. I beg thy holiness to aid in this effort to avoid blockages whilst counting

you see, incorrect grammar. thine is plural, you would want thee in this context.

@ajkachnic
Copy link
Author

day 3 of annoying @kognise into merging this:
pls koggy woggy im begging you pls @kognise merge the pr so my eternal suffering can finally come to an end. the power is in your hands, you can change history; you can stop the blockages in counting; you can finally put an end to this reckless behavior and usher in a new era within #counting and pwnsquad as a whole. you go girl! go merge this pr! go make things happen! you've got this!

@ajkachnic
Copy link
Author

day 4 of requesting for @kognise to merge this: pls just do it so i can stop this daily thing

@ajkachnic
Copy link
Author

day 5 of asking @kognise to merge this: please do it, so i can stop having a random alarm go off reminding me to send this

@ajkachnic
Copy link
Author

day 6 of pleading for @kognise to merge this: please i almost forgot to send this just merge it pls

@kognise
Copy link
Member

kognise commented Oct 25, 2021

@ajkachnic u missed last night 😢

@ajkachnic
Copy link
Author

day 8 of reminding @kognise to merge this (yesterday was the sabbath, your day of rest): aaahhhh please merge it koggy woggy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants